feat: add expo sdk 58 by hurali97 · Pull Request #467 · callstack/react-native-brownfield

hurali97 · 2026-09-17T08:33:38Z

Summary

This upgrades the ExpoApp56 to ExpoApp58. The targetSdk is not allowed to define via the android libraries following the AGP v9, so we keep it ensuring the backward compatibility. A few other changes include: bumping compileSdk to 37 on SDK 58 or later and skipping plugin check.

Test plan

Tested locally
CI passes

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate findings affect release shrinking, SDK compatibility, and initial color-scheme rendering.

Review effort: Lite
Findings: 1 · 1

Open (2)

Use configured package name in R8 keep rule · New
Preserve legacy behavior when expoMajor is omitted · New

What changed in this PR

Upgrades ExpoApp56 to Expo SDK 58 and updates Android compatibility, native integrations, CI, tests, documentation, and example assets.

Changes:

Adds Expo SDK 58 example and consumer variants.
Adds SDK-aware compileSdk and targetSdk handling.
Updates CI, Detox, documentation, and workspace configuration.

File	Review
`scripts/ci-local-appleapp-ios-e2e.sh`	Reviewed
`packages/react-native-brownfield/src/expo-config-plugin/types/android/BrownfieldPluginAndroidConfig.ts`	Reviewed
`packages/react-native-brownfield/src/expo-config-plugin/template/android/proguard-rules.pro`	Changes required: use the configured package name in the keep rule.
`packages/react-native-brownfield/src/expo-config-plugin/template/android/build.gradle.kts`	Reviewed
`packages/react-native-brownfield/src/expo-config-plugin/ios/__tests__/xcodeHelpers.test.ts`	Reviewed
`packages/react-native-brownfield/src/expo-config-plugin/android/withAndroidModuleFiles.ts`	Changes required: preserve legacy behavior when `expoMajor` is omitted.
`packages/react-native-brownfield/src/expo-config-plugin/android/__tests__/withAndroidModuleFiles.test.ts`	Reviewed
`packages/cli/src/types.ts`	Reviewed
`packages/cli/src/expoPluginConfig.ts`	Reviewed
`packages/cli/src/brownfield/utils/project.ts`	Reviewed
`packages/cli/src/brownfield/utils/__tests__/project.test.ts`	Reviewed
`packages/cli/src/__tests__/expoPluginConfig.test.ts`	Reviewed
`packages/cli/schema.json`	Reviewed
`docs/docs/docs/guides/minification.mdx`	Reviewed
`docs/docs/docs/guides/expo-updates/how-to.mdx`	Reviewed
`docs/docs/docs/getting-started/expo.mdx`	Reviewed
`docs/docs/docs/getting-started/examples.mdx`	Reviewed
`docs/docs/docs/api-reference/configuration.mdx`	Reviewed
`CONTRIBUTING.md`	Reviewed
`apps/README.md`	Reviewed
`apps/ExpoApp58/tsconfig.json`	Reviewed
`apps/ExpoApp58/src/utils/expo-rn-updates.ts`	Reviewed
`apps/ExpoApp58/src/hooks/use-theme.ts`	Changes required: normalize a null color scheme to light.
`apps/ExpoApp58/src/hooks/use-color-scheme.web.ts`	Reviewed
`apps/ExpoApp58/src/hooks/use-color-scheme.ts`	Reviewed
`apps/ExpoApp58/src/global.css`	Reviewed
`apps/ExpoApp58/src/constants/theme.ts`	Reviewed
`apps/ExpoApp58/src/components/web-badge.tsx`	Reviewed
`apps/ExpoApp58/src/components/ui/collapsible.tsx`	Reviewed
`apps/ExpoApp58/src/components/themed-view.tsx`	Reviewed
`apps/ExpoApp58/src/components/themed-text.tsx`	Reviewed
`apps/ExpoApp58/src/components/postMessage/MessageBubble.tsx`	Reviewed
`apps/ExpoApp58/src/components/postMessage/Message.ts`	Reviewed
`apps/ExpoApp58/src/components/hint-row.tsx`	Reviewed
`apps/ExpoApp58/src/components/external-link.tsx`	Reviewed
`apps/ExpoApp58/src/components/counter/index.tsx`	Reviewed
`apps/ExpoApp58/src/components/app-tabs.web.tsx`	Changes required: handle a null color scheme with an explicit light fallback.
`apps/ExpoApp58/src/components/app-tabs.tsx`	Changes required: handle a null color scheme with an explicit light fallback.
`apps/ExpoApp58/src/components/animated-icon.web.tsx`	Reviewed
`apps/ExpoApp58/src/components/animated-icon.tsx`	Reviewed
`apps/ExpoApp58/src/components/animated-icon.module.css`	Reviewed
`apps/ExpoApp58/src/app/postMessage.tsx`	Reviewed
`apps/ExpoApp58/src/app/index.tsx`	Reviewed
`apps/ExpoApp58/src/app/explore.tsx`	Reviewed
`apps/ExpoApp58/src/app/_layout.tsx`	Reviewed
`apps/ExpoApp58/RNApp.tsx`	Reviewed
`apps/ExpoApp58/README.md`	Documentation fixes requested for Yarn installation and the missing reset script.
`apps/ExpoApp58/package.json`	Reviewed
`apps/ExpoApp58/jest/cssMock.js`	Reviewed
`apps/ExpoApp58/jest.setup.js`	Reviewed
`apps/ExpoApp58/jest.config.js`	Reviewed
`apps/ExpoApp58/eslint.config.js`	Reviewed
`apps/ExpoApp58/entry.tsx`	Reviewed
`apps/ExpoApp58/CHANGELOG.md`	Reviewed
`apps/ExpoApp58/BrownfieldStore.brownie.ts`	Reviewed
`apps/ExpoApp58/brownfield.navigation.ts`	Reviewed
`apps/ExpoApp58/assets/images/tabIcons/home@3x.png`	Reviewed
`apps/ExpoApp58/assets/images/tabIcons/home@2x.png`	Reviewed
`apps/ExpoApp58/assets/images/tabIcons/home.png`	Reviewed
`apps/ExpoApp58/assets/images/tabIcons/explore@3x.png`	Reviewed
`apps/ExpoApp58/assets/images/tabIcons/explore@2x.png`	Reviewed
`apps/ExpoApp58/assets/images/tabIcons/explore.png`	Reviewed
`apps/ExpoApp58/assets/images/splash-icon.png`	Reviewed
`apps/ExpoApp58/assets/images/react-logo@2x.png`	Reviewed
`apps/ExpoApp58/assets/images/react-logo.png`	Reviewed
`apps/ExpoApp58/assets/images/favicon.png`	Reviewed
`apps/ExpoApp58/assets/images/expo-logo.png`	Reviewed
`apps/ExpoApp58/assets/images/expo-badge.png`	Reviewed
`apps/ExpoApp58/assets/images/expo-badge-white.png`	Reviewed
`apps/ExpoApp58/assets/images/android-icon-monochrome.png`	Reviewed
`apps/ExpoApp58/assets/images/android-icon-background.png`	Reviewed
`apps/ExpoApp58/assets/expo.icon/icon.json`	Reviewed
`apps/ExpoApp58/assets/expo.icon/Assets/expo-symbol 2.svg`	Reviewed
`apps/ExpoApp58/app.json`	Reviewed
`apps/ExpoApp58/.gitignore`	Reviewed
`apps/ExpoApp58/__tests__/brownfield.example.test.tsx`	Reviewed
`apps/brownfield-example-shared-tests/e2e/createDetoxJestConfig.cjs`	Reviewed
`apps/brownfield-example-shared-tests/detox-appleapp-variants.cjs`	Reviewed
`apps/AppleApp/package.json`	Reviewed
`apps/AppleApp/e2e/jest.config.expo58.cjs`	Reviewed
`apps/AppleApp/Brownfield Apple App.xcodeproj/xcshareddata/xcschemes/xcschememanagement.plist`	Reviewed
`apps/AppleApp/Brownfield Apple App.xcodeproj/xcshareddata/xcschemes/Brownfield Apple App Expo 58.xcscheme`	Reviewed
`apps/AppleApp/Brownfield Apple App.xcodeproj/project.pbxproj`	Reviewed
`apps/AppleApp/.detoxrc.expo58.cjs`	Reviewed
`apps/AndroidApp/package.json`	Reviewed
`apps/AndroidApp/gradle/libs.versions.toml`	Reviewed
`apps/AndroidApp/app/src/expo58/java/com/callstack/brownfield/android/expo/ReactNativeHostManager.kt`	Reviewed
`apps/AndroidApp/app/src/expo58/java/com/callstack/brownfield/android/expo/ReactNativeConstants.kt`	Reviewed
`apps/AndroidApp/app/src/expo58/java/com/callstack/brownfield/android/expo/BrownfieldStore.kt`	Reviewed
`apps/AndroidApp/app/build.gradle.kts`	Reviewed
`.github/workflows/ci.yml`	Reviewed
`.github/actions/prepare-android/action.yml`	Reviewed
`.changeset/config.json`	Reviewed

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…nto feat/expo-sdk-58

callstack#467 renamed the Expo 56 app and AppleApp's jest.config.expo56.cjs to expo58, but not AndroidApp's, so .detoxrc.expo58.cjs points at a file that doesn't exist and Detox E2E (AndroidApp - Expo 58) fails with "Can't find a root directory while resolving a config file path".

* fix(bgp): don't force the plugin's AGP version onto consuming apps The plugin declared AGP as an `implementation` dependency, so it ended up on the app's buildscript classpath and won version resolution. Since #448 bumped it to AGP 9.2.1, every consumer gets AGP 9.2.1 and its minimum Gradle 9.4.1, which breaks Expo SDK 57 apps (Gradle 9.3.1): "Minimum supported Gradle version is 9.4.1. Current version is 9.3.1." Compile against AGP but let the app provide it at runtime. Also drop the leftover version matrix from the Expo 57 Android build job, which ran the same Expo 57 build twice. * test(bgp): put AGP on the TestKit plugin classpath GradleRunner.withPluginClasspath() is built from the runtime classpath, which no longer has AGP now that it is compileOnly, so LegacyConsumerConfigurationTest could not apply com.android.library. * test(e2e): rename AndroidApp Jest config for Expo 58 #467 renamed the Expo 56 app and AppleApp's jest.config.expo56.cjs to expo58, but not AndroidApp's, so .detoxrc.expo58.cjs points at a file that doesn't exist and Detox E2E (AndroidApp - Expo 58) fails with "Can't find a root directory while resolving a config file path". * fix(bgp): compile against AGP 8.5.2 With AGP compileOnly the app provides AGP at runtime, but a plugin built against AGP 9.2.1 references AGP 9 only classes and fails on AGP 8 apps: Expo 57 (AGP 8.12) failed with NoClassDefFoundError com/android/build/api/dsl/AndroidLibrarySourceSet. Built against 8.5.2 (the version before #448) it applies on both AGP 8.12.0 and 9.2.1. * fix: make agp compileOnly with test matrix --------- Co-authored-by: Radoslaw Nowacki <radoslaw.nowacki@callastack.com> Co-authored-by: Hur Ali <hurali97@gmail.com>

feat: add expo app 58

08b5951

hurali97 force-pushed the feat/expo-sdk-58 branch from c4027d8 to 08b5951 Compare September 17, 2026 08:59

hurali97 added 3 commits September 17, 2026 17:18

feat: handle targetSDK and compileSDK with backward compat

7f71273

chore: upgrade to expo 58 preview-4

75ff80f

chore: upgrade to preview 7

7d9d400

hurali97 marked this pull request as ready for review September 28, 2026 07:31

Copilot AI lite review requested due to automatic review settings September 28, 2026 07:31

Copilot started reviewing on behalf of hurali97 September 28, 2026 07:31

View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Comment thread packages/react-native-brownfield/src/expo-config-plugin/template/android/proguard-rules.pro Outdated

Comment thread packages/react-native-brownfield/src/expo-config-plugin/android/withAndroidModuleFiles.ts Outdated

hurali97 changed the title ~~Feat/expo sdk 58~~ feat: add expo sdk 58 Sep 28, 2026

hurali97 added 4 commits September 28, 2026 00:59

Merge branch 'main' of github.com:callstack/react-native-brownfield i…

64411f1

…nto feat/expo-sdk-58

fix: code review

e8b365c

chore: run changeset

4c70c19

fix: adopt e2e test for sdk 58

236679f

hurali97 merged commit 31c3939 into main Sep 28, 2026
18 of 19 checks passed

hurali97 deleted the feat/expo-sdk-58 branch September 28, 2026 10:24

github-actions Bot mentioned this pull request Sep 28, 2026

chore(release): version packages #474

Merged

KisaneNeko mentioned this pull request Sep 28, 2026

ci: open an issue when the Expo preview road test fails #471

Merged

KisaneNeko mentioned this pull request Sep 29, 2026

fix(bgp): don't force the plugin's AGP version onto apps #475

Merged

Navigation Menu

Repository navigation

feat: add expo sdk 58 - #467

feat: add expo sdk 58#467
hurali97 merged 8 commits into
mainfrom
feat/expo-sdk-58

hurali97 commented Sep 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hurali97 commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hurali97 commented Sep 17, 2026 •

edited

Loading