Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This targets the Onyx store bump in Expensify#98956.
Every
ReportActionItemrow ranuseOriginalReportIDanduseReportsParentHierarchy. The first rebuilt all of the report's actions into a fresh object in every row on every actions write and deep-compared it, read the full report without a selector, and read the account-wide transactions and violations context. The second subscribed every row to the whole report collection, only to pass the hierarchy to the dismiss-error handler. So editing one message, a write to a heartbeat field of the report, or a write to any report or transaction in the account re-rendered every row.useOriginalReportIDnow checks whether the action belongs to the current report with a boolean selector, reads the three report fields it needs with primitive selectors, and subscribes to the full actions, chat report and transactions only for rows whose action comes from a merged transaction thread. Rows read only the viewed report's ancestor chain through a newuseReportAncestorsHierarchy, which is allclearAllRelatedReportActionErrorswalks.A new reassure test with 500 actions and 10 writes per scenario runs unchanged on the base and on this branch. A write to an unrelated report goes from 364.3 ms to 113.5 ms, editing one visible action from 259.0 ms to 185.6 ms, a write to a heartbeat field of the report from 319.8 ms to 239.4 ms, and a write to an unrelated transaction from 299.1 ms to 225.8 ms. A report name change and mount are unchanged. With 46 rows mounted, editing one action re-renders 1 row instead of 46.
Fixed Issues
$ https://github.com/callstack-internal/expensify-issues/issues/3039
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari