Repository navigation
Conversation
…ydrationGuard Co-authored-by: huult <huult@users.noreply.github.com>
…itedPathForPublicDomain Co-authored-by: huult <huult@users.noreply.github.com>
…ButtonMessageBlocksAddWorkEmail Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
…survey-feedback [Payment due @mkhutornyi] Acknowledge support survey reactions
…atch-4 [No QA] Remove 'group-by:report' example from documentation
…ompanyWorkspace [No QA] Docs updates for E/A#99833 Add Join my company workspace option to help article
…teClearAfter Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
…TypeGuard [Payment due @Krishna2323] Keep the rule editor's form when Describe returns another rule type
…loyeesInWorkflowBuilders Skip null employeeList entries in the Workspaces tab red-dot check
…deHydrationGuard [No QA] [Payment due @huult] Stop routing group workspace members to the reports upgrade screen
usePolicyForMovingExpenses now reads the load status that useOnyx returns for the policy collection, and passes it to isLoadingOnyxValue. The SearchColumnsPage test mocked useOnyx to return only the value, so the metadata was undefined and the test crashed on main with "Cannot read properties of undefined (reading 'status')". Return a loaded status from the mock, as the real hook does.
…h-columns-page-test [NoQA] Fix `SearchColumnsPageTest`
…egateClearAfter Add a clear after date to vacation delegates and show them on the Profile page
…rt-ticket-title [Payment due @ikevin127] [CP stag] Show the support ticket title while creation is pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This targets the Onyx store bump in Expensify#98956.
LHNOptionsListsubscribed to the whole report and policy collections, the report attributes and personal details, looked up each row's policy, invoice receiver policy and one-transaction-thread report, and passed them down. Those collections were also inextraData, so a write to any report or policy re-rendered every visible row.Rows now read their own policy, invoice receiver policy and one-transaction-thread report by member key, and their own report attributes entry. Personal details come from the existing
OnyxListItemProvidercontext. The alternate text still needs the names of other reports (moved or last-action reports), so the list builds one report-name map with a selector, whose reference only changes when a name changes.getOptionDataand the alternate text helpers now only requirereportNamefrom that map.extraDatais down to the list length, the option mode and the network state.A new reassure test with 500 reports runs unchanged on the base and on this branch. A write to one report goes from 158.8 ms to 97.2 ms, and a write to a policy no row uses goes from 85.7 ms to 70.4 ms (28 to 18 renders). Mount and row press are unchanged.
Known issue:
SidebarOrderTest"reorders the reports to always have the most recently updated one on top" fails. FlashList doesn't re-runrenderItemwhen only an item's index changes, so the index-basedDisplayNames-<index>testID goes stale after a reorder, while the order on screen is correct. Before, every report write changedextraData, which refreshed it.Fixed Issues
$ https://github.com/callstack-internal/expensify-issues/issues/3039
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari