[Onyx] Replace RAM_ONLY_SORTED_REPORT_ACTIONS derived value with a memoized useOnyxState hook

[sosek108]

Explanation of Change

This targets the Onyx store bump in Expensify#98956 and builds on the unmerged useOnyxState from react-native-onyx.

RAM_ONLY_SORTED_REPORT_ACTIONS holds the sorted actions, the last action and the one-transaction thread ID of every report. OnyxDerived keeps it alive for the whole session: every REPORT or NETWORK write re-sorts the actions of every report, and every report-action write rebuilds the maps, even though only Search, the Search router, Share and the option-list hooks read it and none of them is mounted during normal inbox use.

This moves the per-report compute, unchanged, into a selector and rebuilds useSortedReportActionsData on useOnyxState over report actions, reports and NETWORK, reading the offline state the same way the config did. The 8 callers don't change. Each report's result is cached on its frozen actions object and reused while the report, its chat report, its transaction thread's actions and the offline state stay the same. The sort itself only reruns when the report's own actions change. When no report changed, the hook returns the previous object, so consumers that key caches on its reference (the option-list cache, the router warmer) keep their cached work. The hook reads the live store, as the derived value did, not the Search snapshot. The config, its key, its type, its RAM-only entry and the deprecated notes pointing at it are removed.

One behaviour is now more correct: the engine's incremental path did not rebuild a parent report when only its transaction thread's actions changed, so its combined list stayed stale until the next full recompute. The selector rebuilds it, giving the same result as a full recompute.

A new reassure test runs unchanged on the base and on this branch over 3,000 reports with 10 actions each. Report and NETWORK writes no longer re-render the readers (11 renders before, 1 now). With the Search router mounted, a loop of report and NETWORK writes takes 440 ms instead of 1,070 ms, and with no Search surface mounted the write loop takes 930 ms instead of 1,630 ms, because nothing is sorted any more when nothing reads the value. Opening the router right after every action changed costs the same on both: the sort moves from the write to the mount.

Fixed Issues

$ https://github.com/callstack-internal/expensify-issues/issues/3082
PROPOSAL:

Tests

1. Open the Search router (Cmd+K or the search icon). Verify recent chats show with the same last-message previews as before.
2. Type part of a report name. Verify matching reports show with their previews.
3. Open a one-expense report's chat from the router results. Verify its preview reflects the expense's thread messages.
4. Send a message in a chat, then open the router again. Verify that chat shows the new message as its preview.
5. Open Share (on a platform that supports it) and verify the destination list shows chats with their previews.
6. In Search, open the "In" filter and verify the report list shows.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline. Delete an expense from a report that has two expenses.
2. Open the Search router. Verify that report's preview shows as before for a report with a pending deleted expense.
3. Go back online. Verify the preview updates once the deletion goes through.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}