Replace NON_PERSONAL_AND_WORKSPACE_CARD_LIST derived value with a memoized useOnyxState hook

[sosek108]

Explanation of Change

This targets the Onyx store bump in Expensify#98956 and builds on the unmerged useOnyxState from the Onyx store work.

NON_PERSONAL_AND_WORKSPACE_CARD_LIST is computed by OnyxDerived from CARD_LIST and every WORKSPACE_CARDS_LIST feed. The engine runs outside React and writes the merged list back into Onyx and to disk on every write to either key. With a large card list, that write is the expensive part: on the base, each card write re-persists the whole merged list even when its content is the same.

This replaces the derived value with a useNonPersonalAndWorkspaceCardList hook on useOnyxState over the same two keys. The merge is the same mergeCardListWithWorkspaceFeeds call with personal cards filtered out. It is memoized on the pair of inputs, so it runs once per write however many consumers are mounted, and a merge with the same content returns the previous object. The hook also keeps each selector's output per merged list, so a write that leaves the list unchanged doesn't make consumers rescan it. Neither key is redirected to the Search snapshot, so Search keeps reading live data. All 11 consumers use the hook. The config, its key and its type are removed. The persisted row is left on disk, as with the TODOS removal.

A new reassure test runs unchanged on the base and on this branch, with 3 expense views and the Search and Home card surfaces mounted. Render counts are the same in every scenario. With 9,000 cards, 10 writes that leave the merged list unchanged go from 1,320 ms to 527 ms for the whole write loop, and 10 renames of a company card go from 1,368 ms to 694 ms. With a small list, the times are within noise.

Fixed Issues

$ https://github.com/callstack-internal/expensify-issues/issues/3078
PROPOSAL:

Tests

1. Sign in to an account with an Expensify Card and a workspace with a company card feed that has assigned cards.
2. Open an expense paid with a company card. Verify the card row shows the card's description.
3. Open Reports > Expenses and group by card. Verify company and workspace cards appear as before, and personal cards are labelled as personal.
4. Verify the Expensify Card suggested search shows in the Search type menu, and the Home insights show the Expensify Card spend card.
5. Select expenses on a company card in Search and use "Change report". Verify the option is offered as before.
6. As a workspace admin, assign a new company card. Verify it shows up in Search's card filter and on the expense without a reload.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline.
2. Open an expense paid with a company card and Reports > Expenses grouped by card. Verify the card names still show.
3. Go back online. Verify nothing changes.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}