Replace CARD_FEED_ERRORS derived value with a memoized useOnyxState hook

[sosek108]

Explanation of Change

This targets the Onyx store bump in Expensify#98956 and builds on the unmerged useOnyxState from react-native-onyx.

CARD_FEED_ERRORS is computed by OnyxDerived from four keys: the card list, the workspace card lists, the domain card feeds and the current date. The engine runs outside React, writes the result back into Onyx and to disk, and every card write hands consumers a new object even when no error changed. Its consumers are mostly report-action items (expense previews, the expense view, the receipt view) and the workspace list rows, so one card write re-renders every one of them that is mounted.

This moves the compute, unchanged, into a pure function and memoizes it on the four input references. useCardFeedErrors stays the single hook every consumer uses; it now reads the four keys with useOnyxState, so one write computes once no matter how many consumers are mounted, and a write that leaves the errors equal keeps the old reference and re-renders nothing. The hook takes an optional selector, which the workspace list row uses to subscribe to its own workspace's RBR flag only. The current date stays a dependency and part of the memo key, because the 90-day grace-period checks read the clock. The config, its key, its type and the second copy of the default error state are removed. The persisted row is left on disk, as with the TODOS removal.

A new reassure test runs unchanged on the base and on this branch, with 10 expense previews and 20 workspace rows mounted. On 10 renames of a healthy card, the previews stop re-rendering (100 preview renders before, 0 now) and the renders take 22 ms instead of 35 ms. The whole write loop over 2,000 workspace cards goes from 265 ms to 150 ms. A write that really changes the errors costs the same on both. The commit count stays at 11 because other card-list subscriptions still re-render the tree on each card write.

Fixed Issues

$ https://github.com/callstack-internal/expensify-issues/issues/3076
PROPOSAL:

Tests

1. As a workspace admin with a company card feed, break one card's bank connection (or use an account where one is broken).
2. Open Workspaces. Verify the RBR dot shows on that workspace's row and not on the others.
3. Open the workspace and Company cards. Verify the broken connection message and the "log into your bank" fix show as before.
4. Open Settings > Wallet. Verify the broken card shows its error as before.
5. As the card holder, open a chat with an expense made on a personal card whose connection is broken. Verify the expense preview and the expense view show the fix-connection link.
6. Fix the connection. Verify the RBR dot, the wallet error and the fix-connection link go away.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline.
2. Verify the workspace row RBR dot and the expense preview fix-connection link stay as they were online.
3. Go back online. Verify they still match the card state.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}