Repository navigation
Conversation
…tent photo preview step Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
…vior Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
Co-authored-by: Jairo Calmon <heekinho@users.noreply.github.com>
… let the column sort stand alone Product narrowed the expected behaviour: the table just obeys the selected column (Date by default), and category/tag group order stays alphabetical as a separate axis. - Revert src/libs/ReportLayoutUtils.ts and tests/unit/ReportLayoutUtilsTest.ts to their pre-PR state; the group comparator and its 8 tests are no longer needed. - Delete the RBR hoist from the table sort along with isDefaultSort, hasUserSortedTransactions, the per-report sort reset and the rbrTransactionIDs memo. reportActionsMap only fed transactionHasRBR, so the report-actions pass now builds just the transaction-thread map, and getActionErrorsByTransaction over every report action is gone from the default report open. - Update the RHP arrow order test for the new Date DESC order and drop the per-report sort reset test. Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
…one line Removing getActionErrorsByTransaction left the remaining six named imports short enough for oxfmt to fold the multi-line form back onto a single line. Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
…nces - Spell out the transactionID to transaction-thread-report-ID mapping in words instead of using an arrow. - Split the FlashList comment's semicolon into two sentences. Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
- Drop the 100 m recording-interval detail; the Edit icon is gated on trip distance (canGpsTripBeTrimmed), and the interval is 50 m since Expensify#101431 - Show the distance as 0.00 to match DISTANCE_DECIMAL_PLACES - Note that discarding via the trash icon requires a confirmation - Tighten the Can't create expense paragraph - Add the can't create expense keyword Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
Save only shows the modal when distanceInMeters === 0, so a trip that loops back to its start point still saves. Also bold the Stop button name in the FAQ heading per HELPSITE_NAMING_CONVENTIONS. Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
Tapping Stop before the first GPS fix arrives leaves gpsPoints as [[]], so isTripStopped is false, the Waypoints block unmounts, and the Start button renders again. Worded around the location being found, not the start address appearing, since point recording and address resolution are decoupled. Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
The start waypoint falls back to raw coordinates when offline or when the reverse geocode returns nothing, so both rows may show coordinates rather than an address. Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
- Name the feature in the heading and scope it to a new trip: after Resume, stopping without moving drops the empty segment and returns to the earlier trip, so the 0.00 answer only holds for a trip you just started - Say updated end location, since a trim saved offline or with no geocode result stores coordinates rather than an address Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
…edPaidExpenses # Conflicts: # src/pages/Search/SearchEditMultiple/SearchEditMultiplePage.tsx
…-access-restricted-request-access Docs updates for E/A#100319 Request admin access from Access restricted screen
…ction-status-filter [no QA] Docs updates for E/A#100637 document transaction-status search operator
…WithoutMoving [No QA] Docs updates for E/A#101027 GPS trip stopped without moving
…ng-travel-home [no QA] Docs updates for E/A#101385 Cancelled reservations excluded from Upcoming travel
…meraChatAttachments [No QA] Docs updates for E/A#96458 in-app camera for chat attachment photos
…tsDocs [No QA] Docs updates for E/A#99591 HR sync complete screen wording and manual sync steps
…ment-frequency-currency-fees-save [No QA] Docs updates for E/A#99235 Save button for settlement frequency and conversion fees
…ceMembersInviteFlow Docs updates for E/A#98564 correct Workspace Members invite flow steps
…ExportStep Docs updates for E/A#99217 Export step added to grouped export instructions
…roupPreferredWorkspaceSearch Docs updates for E/A#100147 Domain group Preferred Workspace search and label fixes
…removal-docs [No QA] Docs updates for E/A#99418 Rillet integration now generally available
…te-unreported-expense [No QA] Docs updates for E/A#98396 Clarify duplicating an unreported expense stays unreported
…-ready-over-concierge [no QA] Docs updates for E/A#101115 export window shows ready state after Concierge request
…splits-91995 [No QA] Docs updates for E/A#91995 self-DM unreported expenses can be split
[CP Staging] Prefill personal detail for user created via public room
…0-exitto-keep-tab Keep the current tab when opening an exitTo link from a signed-in val…
…rovedPaidExpenses Allow admins to bulk edit expenses on approved and paid reports
…ormat Fix MONTH_FORMAT and getFormattedQuarterForSearch to respect locale
…et-vendor-matching-beta Remove the vendor matching beta for Rillet
…dalHelpDocs [No QA] Docs updates for E/A#99341 Pay report global reimbursements prompt
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges main into
fix/lhn-search-preview-parity, resolving the singleInSelector.tsxconflict as a union of both sides' additions.Expensify#101298