Skip to content

Melvin r2: drop search preview precompute, derived OTT ID, remove card plumbing - #69

Merged
sosek108 merged 1 commit into
fix/lhn-search-preview-parityfrom
fix/lhn-search-preview-parity-melvin-r2
Sep 22, 2026
Merged

sosek108 merged 1 commit into
fix/lhn-search-preview-parityfrom
fix/lhn-search-preview-parity-melvin-r2

Conversation

@sosek108

Copy link
Copy Markdown

Preview of the second-round Melvin review fixes on top of fix/lhn-search-preview-parity (Expensify#101298).

  • Search preview path no longer forwards option.lastMessageText into getReportAlternateText — the LHN never forwards a precompute either, so both surfaces now always build the text from the full input set (fixes DEW queued-to-submit/approve and archived-reason actor divergences).
  • LHN forwards oneTransactionThreadReportID (from derived report attributes) and visibleReportActionsData to the shared text builder, so LHN and Search resolve transaction threads and action visibility identically.
  • Removed the PR-introduced cardList/workspaceCardList plumbing: it can never change preview text on this path and only poisoned the preview-cache invalidation.
  • Perf harness gained a reset export + two cold-cache scenarios.

Gates: lint-changed, react-compiler-compliance check-changed, typecheck (only pre-existing VictoryChart errors), parity suite 157 pass, OptionsListUtilsTest 333 pass.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: a590f8af-b37c-4ce4-8b0e-e0a5413500f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@sosek108
sosek108 merged commit e9e30ce into fix/lhn-search-preview-parity Sep 22, 2026
3 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant