Repository navigation
Melvin r2: drop search preview precompute, derived OTT ID, remove card plumbing - #69
Merged
sosek108 merged 1 commit intoSep 22, 2026
Conversation
… derived OTT ID, remove dead card plumbing
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
sosek108
merged commit Sep 22, 2026
e9e30ce
into
fix/lhn-search-preview-parity
3 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview of the second-round Melvin review fixes on top of
fix/lhn-search-preview-parity(Expensify#101298).option.lastMessageTextintogetReportAlternateText— the LHN never forwards a precompute either, so both surfaces now always build the text from the full input set (fixes DEW queued-to-submit/approve and archived-reason actor divergences).oneTransactionThreadReportID(from derived report attributes) andvisibleReportActionsDatato the shared text builder, so LHN and Search resolve transaction threads and action visibility identically.cardList/workspaceCardListplumbing: it can never change preview text on this path and only poisoned the preview-cache invalidation.Gates: lint-changed, react-compiler-compliance check-changed, typecheck (only pre-existing VictoryChart errors), parity suite 157 pass, OptionsListUtilsTest 333 pass.