Repository navigation
[No QA] Route personal details writes through buildPersonalDetailsUpdate - #67
Closed
TMisiukiewicz wants to merge 4 commits into
Closed
TMisiukiewicz wants to merge 4 commits into
TMisiukiewicz wants to merge 4 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Expensify#101096
Part of Expensify#101083
Routes every
ONYXKEYS.PERSONAL_DETAILS_LISTwrite throughbuildPersonalDetailsUpdatefrom@libs/PersonalDetailsUtils, so a single helper owns turning one list update into the per-account update after the reshape.What changed
{ onyxMethod: MERGE, key: PERSONAL_DETAILS_LIST, value }onyxData payload and directOnyx.merge(PERSONAL_DETAILS_LIST, ...)(nowOnyx.update([buildPersonalDetailsUpdate(...)])) across the 20 in-scope files.PersonalDetailsOnyxUpdatealias (ReturnType<typeof buildPersonalDetailsUpdate>) instead of naming the key in anOnyxUpdategeneric. Multi-key unions were split intoOnyxUpdate<otherKeys> | PersonalDetailsOnyxUpdate.rulesdir/no-direct-personal-details-listseatbelt accordingly; entries for fully-migrated files were removed.Notes
Onyx.update([update])resolves to the samemerge(key, value)call asOnyx.merge.PERSONAL_DETAILS_LISTreferences are read-only (Onyx.connect,update.key ===comparisons, snapshot writes) and a couple ofOnyxData<typeof PERSONAL_DETAILS_LIST>param types — those belong to the reads / key-reshape sub-issues, so their seatbelt counts were only reduced, not removed.