Repository navigation
Add web-only floating RHP style - #66
Closed
BartekObudzinski wants to merge 1 commit into
Closed
BartekObudzinski wants to merge 1 commit into
BartekObudzinski wants to merge 1 commit into
Conversation
Inset the RHP from the viewport edges with rounded corners, a 1px border and a shadow, and lighten its scrim. Web wide layout only; narrow layout and native keep the current full-bleed frame.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Author
|
not here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On web wide layout the RHP now "floats": it is inset 12px from the top/right/bottom edges and gets rounded corners, a 1px border, and a shadow, while its background scrim uses a lighter color and lower opacity. The change is gated on
Platform.OS === 'web' && !shouldUseNarrowLayout, so narrow layout and native keep the current full-bleed frame. RHP width is unchanged, so this is purely presentational and web-only.Fixed Issues
$ Expensify#100811
PROPOSAL:
Tests
Offline tests
These are presentational, web-only changes with no network dependency; offline behavior matches online.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari