Fix Vim navigation outside main panel - #3
Merged
Merged
Conversation
callmiy
marked this pull request as ready for review
July 20, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes the Vim-style main-panel navigation imported from upstream PR jesseduffield#816.
ggandGavailable while a normal non-editable side panel retains focus.ggsequence window from 250 ms to 1 second.Gidempotent, so bothGand repeatedGGland on the final page.gsequence when jumping to the bottom.ggcorrectly in options/help and regenerated cheatsheets.Root cause
PR jesseduffield#816 registered both keys only for the
mainview. Container Config is normally viewed while Services or Containers retains focus, so the keys were ignored. Its 250 ms double-press window was also too short for normal human input.Live validation
Validated the patched binary in a dedicated tmux session against the live
accloud-ldeDocker environment:g, waited 500 ms, then pressedg; content returned to the first line.G, waited 500 ms, then pressedG; content landed on and remained at the final page.ggandG.Automated validation
bash ./test.sh(race-enabled package suite)go run scripts/cheatsheet/main.go checkgo mod vendorwith no diffgofmt -scheck