Skip to content

Fix Vim navigation outside main panel - #3

Merged
callmiy merged 1 commit into
personalfrom
fix/vim-main-navigation
Jul 20, 2026
Merged

callmiy merged 1 commit into
personalfrom
fix/vim-main-navigation

Conversation

@callmiy

@callmiy callmiy commented Jul 20, 2026

Copy link
Copy Markdown
Owner

What changed

Fixes the Vim-style main-panel navigation imported from upstream PR jesseduffield#816.

  • Makes gg and G available while a normal non-editable side panel retains focus.
  • Extends the gg sequence window from 250 ms to 1 second.
  • Keeps G idempotent, so both G and repeated GG land on the final page.
  • Clears a pending g sequence when jumping to the bottom.
  • Displays gg correctly in options/help and regenerated cheatsheets.
  • Rejects negative elapsed-time values in double-press detection.

Root cause

PR jesseduffield#816 registered both keys only for the main view. Container Config is normally viewed while Services or Containers retains focus, so the keys were ignored. Its 250 ms double-press window was also too short for normal human input.

Live validation

Validated the patched binary in a dedicated tmux session against the live accloud-lde Docker environment:

  1. Focused Services and opened Container Config without entering Main.
  2. Scrolled several pages into a long live container configuration.
  3. Pressed g, waited 500 ms, then pressed g; content returned to the first line.
  4. Pressed G, waited 500 ms, then pressed G; content landed on and remained at the final page.
  5. Confirmed the side-panel footer advertises gg and G.

Automated validation

  • bash ./test.sh (race-enabled package suite)
  • Linux, Windows, and macOS builds
  • go run scripts/cheatsheet/main.go check
  • go mod vendor with no diff
  • gofmt -s check

@callmiy
callmiy marked this pull request as ready for review July 20, 2026 23:19
@callmiy
callmiy merged commit eb6afe9 into personal Jul 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant