Update function calls and environment - #4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates DIMS/HABC lipidomics code to remove clamr::-qualified calls, add default_tg_is_ms3 loading/usage, adjust figure scripts for repository-relative paths, and introduce an renv.lock for environment reproducibility.
Changes:
- Replaced several namespaced
clamr::calls with local function references and addeddefault_tg_is_ms3loading/parameter passing. - Updated figure Rmd setup chunks by removing unused libraries and using
here::here(). - Added a new
renv.lockintended to pin package versions.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
renv.lock |
Adds an R environment lockfile. |
R/habc4_lipids.R |
Loads default_tg_is_ms3 and switches MS3/helper calls to local references. |
R/habc_lipids.R |
Loads default_tg_is_ms3 and switches HABC helper/search calls to local references. |
R/docr_lipids.R |
Renames/updates DOCR processing function and passes MS3 IS library as an argument. |
R/direct_infusion.R |
Updates documentation and local helper call references. |
inst/scripts/lipidomics-dims-script.R |
Loads/passes default_tg_is_ms3 into positive-mode DOCR processing. |
inst/figures/Figure_5.Rmd |
Removes unused library imports. |
inst/figures/Figure_4.Rmd |
Removes unused imports and uses here::here() for the local path. |
inst/figures/Figure_3.Rmd |
Removes unused imports, uses here::here(), and updates extdata paths. |
inst/figures/Figure_1_2.Rmd |
Removes unused imports and uses here::here() for the local path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update file paths and package calls to reduce errors
Make an renv.lock file for environment reproducibility
Issue ticket number and link
#3
Type of change
(If applicable) How has this been tested?