Skip to content

Update function calls and environment - #4

Merged
johanna0321 merged 2 commits into
mainfrom
issue-3
May 18, 2026
Merged

Update function calls and environment#4
johanna0321 merged 2 commits into
mainfrom
issue-3

Conversation

@johanna0321

Copy link
Copy Markdown
Collaborator

Description of your changes

Update file paths and package calls to reduce errors
Make an renv.lock file for environment reproducibility

Issue ticket number and link

#3

Type of change

  • Bug fix
  • New feature
    • Backwards Incompatible?
  • Refactoring / code clean-up
  • Documentation add / update
  • Automated Test
  • Other (please specify)

(If applicable) How has this been tested?

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates DIMS/HABC lipidomics code to remove clamr::-qualified calls, add default_tg_is_ms3 loading/usage, adjust figure scripts for repository-relative paths, and introduce an renv.lock for environment reproducibility.

Changes:

  • Replaced several namespaced clamr:: calls with local function references and added default_tg_is_ms3 loading/parameter passing.
  • Updated figure Rmd setup chunks by removing unused libraries and using here::here().
  • Added a new renv.lock intended to pin package versions.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
renv.lock Adds an R environment lockfile.
R/habc4_lipids.R Loads default_tg_is_ms3 and switches MS3/helper calls to local references.
R/habc_lipids.R Loads default_tg_is_ms3 and switches HABC helper/search calls to local references.
R/docr_lipids.R Renames/updates DOCR processing function and passes MS3 IS library as an argument.
R/direct_infusion.R Updates documentation and local helper call references.
inst/scripts/lipidomics-dims-script.R Loads/passes default_tg_is_ms3 into positive-mode DOCR processing.
inst/figures/Figure_5.Rmd Removes unused library imports.
inst/figures/Figure_4.Rmd Removes unused imports and uses here::here() for the local path.
inst/figures/Figure_3.Rmd Removes unused imports, uses here::here(), and updates extdata paths.
inst/figures/Figure_1_2.Rmd Removes unused imports and uses here::here() for the local path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread inst/scripts/lipidomics-dims-script.R Outdated
Comment thread R/habc_lipids.R
Comment thread R/habc4_lipids.R
Comment thread R/docr_lipids.R Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Comment thread R/habc_lipids.R
Comment thread R/habc4_lipids.R
Comment thread R/docr_lipids.R
Comment thread R/dims_normalization.R
@johanna0321
johanna0321 merged commit 0de0e09 into main May 18, 2026
1 check passed
@johanna0321
johanna0321 deleted the issue-3 branch May 18, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants