Repository navigation
docs: document the assistant build flag and widen its e2e coverage - #567
Merged
Merged
Conversation
|
Automatic reviews are disabled for this repository. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
The assistant panel had no documentation for the build flag that keeps it out of the default bundle, the security notes did not describe how answers are rendered, and the panel's e2e spec covered neither the phone layout, Czech, nor the dark theme. One Escape test waited on a fixed 500 ms sleep.
Change
frontend/README.md: an Assistant section with theVITE_ASSISTANT_ENABLEDbuild flag (off by default), where the feature lives, the backend switch, and how to run its e2e spec without a backend.docs/security.md: assistant answers go through react-markdown with an element allowlist, no raw-HTML plugin, and https-only source links.m-0on the clear-confirmation fieldset is removed (Tailwind preflight already zeroes it).Verification
npm run build: no assistant string, i18n key or endpoint path indist/assets/*.js(grep for the composer placeholder in en and cs,/assistant/chat,/assistant/config,trigger.header,composer.placeholder, the storage key prefix). WithVITE_ASSISTANT_ENABLED=truethe same terms are found in the lazy chunks.VITE_ASSISTANT_ENABLED=true npx playwright test e2e/assistant-panel.spec.ts --project=chromium: 13 passed.npm run lint,npm run typecheck,npm run test:coverage(thresholds held).Migrations
None.
Screenshots
None.