Skip to content

docs: document the assistant build flag and widen its e2e coverage - #567

Merged
caitlon merged 3 commits into
devfrom
feat/assistant-panel-finish
Oct 11, 2026
Merged

caitlon merged 3 commits into
devfrom
feat/assistant-panel-finish

Conversation

@caitlon

@caitlon caitlon commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Problem

The assistant panel had no documentation for the build flag that keeps it out of the default bundle, the security notes did not describe how answers are rendered, and the panel's e2e spec covered neither the phone layout, Czech, nor the dark theme. One Escape test waited on a fixed 500 ms sleep.

Change

  • frontend/README.md: an Assistant section with the VITE_ASSISTANT_ENABLED build flag (off by default), where the feature lives, the backend switch, and how to run its e2e spec without a backend.
  • docs/security.md: assistant answers go through react-markdown with an element allowlist, no raw-HTML plugin, and https-only source links.
  • e2e: the panel as a sheet on a 390x844 viewport, the dialog in Czech, and the dialog in dark theme with an axe audit; the fixed sleep in the Escape test is gone.
  • A redundant m-0 on the clear-confirmation fieldset is removed (Tailwind preflight already zeroes it).

Verification

  • Default npm run build: no assistant string, i18n key or endpoint path in dist/assets/*.js (grep for the composer placeholder in en and cs, /assistant/chat, /assistant/config, trigger.header, composer.placeholder, the storage key prefix). With VITE_ASSISTANT_ENABLED=true the same terms are found in the lazy chunks.
  • VITE_ASSISTANT_ENABLED=true npx playwright test e2e/assistant-panel.spec.ts --project=chromium: 13 passed.
  • npm run lint, npm run typecheck, npm run test:coverage (thresholds held).

Migrations

None.

Screenshots

None.

@caitlon caitlon added this to the v1.1-polish milestone Oct 11, 2026
@caitlon caitlon added type:docs Documentation area:frontend React frontend labels Oct 11, 2026
@greptile-apps

greptile-apps Bot commented Oct 11, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository.

@caitlon caitlon self-assigned this Oct 11, 2026
@github-actions github-actions Bot added the size:S Under 300 changed lines. label Oct 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@caitlon
caitlon merged commit 61df255 into dev Oct 11, 2026
20 of 22 checks passed
@caitlon
caitlon deleted the feat/assistant-panel-finish branch October 11, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend React frontend size:S Under 300 changed lines. type:docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant