Repository navigation
fix: keep tag-like text and numeric citations in assistant answers - #566
Merged
Merged
Conversation
|
Automatic reviews are disabled for this repository. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
Assistant answers lost text that looks like a tag:
x<y and y>zrendered asxz, because raw HTML was skipped. A line such as[1]: https://...in an answer became a markdown link definition, so every[1]citation lost its brackets. The local-source hint still called the corpus private.Change
unwrapDisallowedstay, andrehype-rawis still absent, so no HTML element can be created from an answer.[n]: ..., also behind list or quote markers) has its opening bracket escaped before parsing, so it stays plain text and the citations keep working. Top-level code blocks and non-numeric definitions are untouched.AssistantMarkdowndescribes how[n]actually renders.react-markdownlisted in the frontend tech stack.Verification
npm run lint,npm run typecheck,npm run test:coverage(thresholds held).<script>/<img onerror>in an answer is shown as text and never becomes an element; the test fails ifskipHtmlcomes back.Migrations
None.
Screenshots
None, text-only change.