fix(zset): acquire write lock in RemoveRangeByScoreWithOpt - #268
Open
bodapatisaikrishna wants to merge 1 commit into
Open
bodapatisaikrishna wants to merge 1 commit into
bodapatisaikrishna wants to merge 1 commit into
Conversation
RemoveRangeByScoreWithOpt modifies the underlying skiplist and dict via DeleteRangeByScore, but was previously acquiring a read lock (RLock) instead of an exclusive write lock (Lock). This caused data races and concurrent map write panics when RemoveRangeByScore was called concurrently. Acquire Lock/Unlock instead, and add TestFloat64SetRemoveRangeByScoreConcurrently to verify concurrent safety. Fixes bytedance#234 Signed-off-by: bodapatisaikrishna <saikrishnabodapati@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Float64Set.RemoveRangeByScoreWithOptdeletes elements from the skiplist and dictionary viaz.list.DeleteRangeByScore(min, max, opt, z.dict). However, it acquired a read lock (z.mu.RLock()) instead of an exclusive write lock (z.mu.Lock()).When
RemoveRangeByScoreis executed concurrently, multiple goroutines enterDeleteRangeByScoresimultaneously, resulting infatal error: concurrent map writesor data races.Fixes #234.
Solution
z.mu.Lock()/defer z.mu.Unlock()inRemoveRangeByScoreWithOptto serialize modifications to the skiplist and map.TestFloat64SetRemoveRangeByScoreConcurrentlyincollection/zset/zset_test.goto test concurrent executions ofRemoveRangeByScoreunder-race.Verification
All tests in
collection/zsetpass with-race: