Skip to content

fix: allow Frappe v16 pre-releases in frappe-dependencies - #18

Closed
harshtandiya wants to merge 1 commit into
mainfrom
fix/frappe-dependencies-v16-compat
Closed

fix: allow Frappe v16 pre-releases in frappe-dependencies#18
harshtandiya wants to merge 1 commit into
mainfrom
fix/frappe-dependencies-v16-compat

Conversation

@harshtandiya

Copy link
Copy Markdown
Contributor

Changes [tool.bench.frappe-dependencies] lower bound from >=16.0.0 to >=16.0.0-dev.

Bench validates with semantic_version SimpleSpec, which excludes pre-releases (e.g. 16.0.0-dev, 16.0.0-beta.1) unless the range includes a pre-release bound. Without the -dev suffix, Frappe Cloud / bench validation can reject v16 develop/beta benches. Upper bound <18.0.0 keeps v16+v17 compat.

Verified locally: 16.0.0-dev/17.0.0-dev satisfy the new spec; 18.0.0-dev does not.

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adjusts Bench’s Frappe dependency constraint so supported v16 and v17 prerelease builds can pass dependency validation while retaining the existing v18 upper bound.

  • Changes the lower bound from 16.0.0 to 16.0.0-dev.
  • Leaves the <18.0.0 compatibility boundary intact.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or repository-rule issues identified.

The constraint change is narrowly scoped to prerelease eligibility, remains consistent with the stated v16 and v17 support intent, and preserves the existing v18 exclusion boundary.

Important Files Changed

Filename Overview
pyproject.toml Broadens the Bench-managed Frappe dependency range to include intended v16 and v17 prereleases without changing the major-version ceiling.

Reviews (1): Last reviewed commit: "fix: allow Frappe v16 pre-releases in fr..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant