fix: allow Frappe v16 pre-releases in frappe-dependencies - #18
Closed
harshtandiya wants to merge 1 commit into
Closed
fix: allow Frappe v16 pre-releases in frappe-dependencies#18harshtandiya wants to merge 1 commit into
harshtandiya wants to merge 1 commit into
Conversation
Greptile SummaryThis PR adjusts Bench’s Frappe dependency constraint so supported v16 and v17 prerelease builds can pass dependency validation while retaining the existing v18 upper bound.
Confidence Score: 5/5The PR appears safe to merge, with no actionable correctness, security, or repository-rule issues identified. The constraint change is narrowly scoped to prerelease eligibility, remains consistent with the stated v16 and v17 support intent, and preserves the existing v18 exclusion boundary.
|
| Filename | Overview |
|---|---|
| pyproject.toml | Broadens the Bench-managed Frappe dependency range to include intended v16 and v17 prereleases without changing the major-version ceiling. |
Reviews (1): Last reviewed commit: "fix: allow Frappe v16 pre-releases in fr..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
[tool.bench.frappe-dependencies]lower bound from>=16.0.0to>=16.0.0-dev.Bench validates with semantic_version SimpleSpec, which excludes pre-releases (e.g. 16.0.0-dev, 16.0.0-beta.1) unless the range includes a pre-release bound. Without the -dev suffix, Frappe Cloud / bench validation can reject v16 develop/beta benches. Upper bound <18.0.0 keeps v16+v17 compat.
Verified locally: 16.0.0-dev/17.0.0-dev satisfy the new spec; 18.0.0-dev does not.