fix: keep host controls in view with a full room - #10
Merged
Conversation
The lobby chip grid and the podium leaderboard grew with the player count, so at 500+ players the Start game and New game buttons landed below the fold of a projector. Both lists now scroll inside the space left over, with a bottom fade so the cut-off row reads as more content rather than a clip.
Past the top 25 the list is names nobody reads off a projector, and the scroll to reach the bottom of 500 rows is longer than the moment lasts.
Making the chip grid a flex-1 scroller left slack under the rows in a small lobby, and align-content: stretch grew every wrapped line to fill it, so the rounded-full chips rendered as blobs.
flex-1 gave both scrollers more height than their content in a small room, which stretched the chip rows and stranded them below the player count. They now shrink out of the leftover space only when the list overflows. Drops the bottom fade with it: the mask ran whether or not the list scrolled, so it dimmed the last row of a lobby that fit on screen.
Reuses no-scrollbar from the avatar strip. A cut-off row already says the list runs on, and a bar down the side of a projected game is noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a large room (500+ players), the lobby chip grid and the final-results leaderboard grew with the player count and pushed Start game and New game below the fold of the projector. The host had to scroll to run the game.
Solution
Both lists now scroll inside the space left over instead of growing the page, so the control row stays put at any player count. A bottom fade makes the cut-off row read as more content rather than a clip.
Verified with 500 players at 1920x1080, 1366x768 and 390x844. The per-question results screen needed nothing: the server already caps
top_5at 5 andstreaksat 3.