refactor(notifications): build the notification intent without apply - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears code scanning alert #1,
java/android/implicit-pendingintents, high, atNotificationHelper.kt:95.False positive. The intent already names its destination component and the PendingIntent already carries
FLAG_IMMUTABLE, which are the two things the rule asks for; the query'sExplicitIntentSanitizerbarrier needs local data flow from the constructor carrying theClassargument, andIntent(...).apply { }routes the value throughkotlin.applyinstead. Setting the fields on a local val restores that flow. Action, flags, data, request code and notification behaviour are unchanged.CodeQL also gains
workflow_dispatch, since it runs only on trunk pushes and a weekly cron today.