fix(navigation): remove legacy desk fixtures - #449
Merged
Conversation
Contributor
Greptile SummaryRemoves the legacy Buzz Workspace Sidebar and its dependent Desktop Icon fixture so Frappe uses the modern generated navigation mechanisms instead.
Confidence Score: 5/5The PR appears safe to merge because it removes only legacy navigation fixtures while retaining the supported Buzz Workspace and apps-screen registration. No concrete behavioral, security, or repository-rule violation remains after verifying the supported Frappe range and the retained navigation configuration.
|
| Filename | Overview |
|---|---|
| buzz/desktop_icon/buzz.json | Deletes the legacy Desktop Icon that linked to the retired Buzz Workspace Sidebar. |
| buzz/workspace_sidebar/buzz.json | Deletes the legacy Workspace Sidebar while the supported modern Buzz Workspace remains available. |
Reviews (1): Last reviewed commit: "Merge branch 'develop' into fix/remove-l..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Frappe develop fails while converting the legacy Buzz sidebar because its title is Buzz, its module is Events, and Buzz is also a registered module name. Removing the retired fixtures avoids that invalid conversion path.
Verification