Repository navigation
chore: sync ts-testing-all conventions - #16
Merged
Merged
Conversation
The repo has a TypeScript test suite, so it syncs the testing rules shared across suites. Also brings the already-synced convention files up to date with upstream. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GrSSi8k4q48PmHCXCMFVrN
Contributor
PR Diff Line Count
|
||||||||||||||||||||||||||||||||||||
Contributor
|
Size Change: 0 B Total Size: 1.42 kB ℹ️ View Unchanged
|
Matches the order the bvandrc-conventions README recommends. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GrSSi8k4q48PmHCXCMFVrN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Blake · project thread
Before: bvandrc-conventions#19 moved the testing rules shared by every suite into a new
ts-testing-all.md, but this repo's sync workflow didn't list it, so those rules would have dropped out on the next sync.After: the sync keeps
conventions/ts-testing-all.mdcurrent, andCLAUDE.mdimports it alongside the other convention files.How: added
ts-testing-all.mdtofiles:in.github/workflows/sync-conventions.yml, ahead of the suite-specific files that build on it, and added its@conventions/line toCLAUDE.md. The markdown files underconventions/are copied from upstreammain, the same content the next sync would bring, so the rules that moved out of the other files aren't missing in the meantime.🤖 Generated with Claude Code
https://claude.ai/code/session_01GrSSi8k4q48PmHCXCMFVrN
Generated by Claude Code