Repository navigation
build: mark the package side-effect free - #15
Merged
Merged
Conversation
No module runs anything at import time, so a consumer's bundler can drop whatever it does not use. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YWdSih7WB25vSSmht9igpG
Contributor
PR Diff Line Count
|
||||||||||||||||||||||||
Contributor
|
Size Change: 0 B Total Size: 1.42 kB ℹ️ View Unchanged
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YWdSih7WB25vSSmht9igpG
bvandrc
marked this pull request as ready for review
September 26, 2026 00:10
bvandrc
added a commit
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Blake · project thread
Before: a consumer's bundler has to assume importing
react-component-test-suitemay run something, so it can't drop unused parts of it.After:
"sideEffects": falsetells it nothing runs at import time, so unused exports tree-shake away.How: reviewed
src/component-suite.tsxandsrc/utils/index.ts; both are declarations only. Test-runner hooks are only registered when a suite function is called, never at module scope. The key sits afterfiles, wherelint-package-jsonwants it.🤖 Generated with Claude Code
https://claude.ai/code/session_01YWdSih7WB25vSSmht9igpG