Conversation
…o resolve pandas FutureWarning Fixes bukosabino#354, bukosabino#357, bukosabino#348 In PSARIndicator._run(), line 1030 used self._psar[i] = high2 (positional integer indexing on a pandas Series), which triggers a FutureWarning in pandas >= 2.0 and Python 3.12+. All surrounding code in the same method already correctly uses .iloc[i]. This single inconsistent line caused the warning reported in issues bukosabino#354, bukosabino#357 and bukosabino#348.
Author
|
"Note: the ci/circleci: test_py36 failure is pre-existing and also fails on the current master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
FutureWarning(and eventual crash in future pandas versions) inPSARIndicator._run()inta/trend.py.Testing
Manually verified PSARIndicator runs without FutureWarning on a 60-bar OHLC dataset containing a trend reversal (which triggers the affected code path).