Add Plotly-based feature visualization examples and docs links - #363
chandraveshchaudhari wants to merge 4 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
atharvajoshi01
left a comment
There was a problem hiding this comment.
Nice visualizations, the Plotly charts look good. A few things I noticed:
-
The committed notebook outputs add ~116k lines to the diff. Stripping outputs before commit (via nbstripout or clearing cells manually) would keep the repo lean and let users generate the charts themselves.
-
The helper functions (COLUMN_ALIASES, _find_column, load_nse_history, etc.) are duplicated across all 5 notebooks. A shared utility module in the same folder would cut the boilerplate.
-
The column headers in the CSV have trailing spaces which is why you need the alias matching logic. Stripping the headers in the CSV itself would simplify things.
-
The README TODO removal mentions Streamlit as addressed but only Plotly is covered here.
The charting code itself is clean and correct.
…ed a new utility file for category notebooks.
|
Thanks, I have addressed all points. Please see the summary of changes:
|
|
Please review and merge my pull request |
This PR addresses the visualization TODO by adding Plotly-based examples for technical indicator exploration.
What changed
Why this change
Scope
Validation