Conversation
Groni3000
marked this pull request as ready for review
November 5, 2023 18:04
Contributor
Author
|
Timeit info based on QQQ quotes. |
Contributor
Author
|
Btw, based on #288 issue, I suggest to delete that row: self._atr.iloc[:self._window-1] = 0 |
any update on this @Groni3000 |
Contributor
Author
|
@Khalizo What do you mean by "updates"? I just suggested deleting the unnecessary row to fix an additional issue. It would be great to hear maintainer/s opinions! Only after this we can make updates or just merge it as it is right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #326. Now it satisfies tests.