chore(repo): Add oxlint, oxfmt, and CI workflow#9
Merged
Conversation
Introduce type-aware linting and formatting across the workspace, matching the either/releases toolchain. CI runs pnpm types before oxlint because worker-configuration.d.ts is gitignored.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Zach Dunn (zachdunn)
changed the title
Resolve conflicts in CLI exports and commands from #8 (GitHub attachments). Fix no-array-sort in github.ts, extend CI to run uploads package tests, and add uploads/test to oxlint overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxlint-tsgolint) and oxfmt across the workspace, following the same config pattern aseitherandreleasespnpm lint,pnpm format,pnpm check@uploads/storagetest jobspnpm typesin CI before oxlint becauseworker-configuration.d.tsis gitignoredLint fixes
returnin CLI mainTest plan
pnpm types && pnpm checkpasses locallypnpm --filter @uploads/storage testpasses (19 tests)