Skip to content

fix(api): set Cache-Control: max-age=60 on uploads so overwrites propagate #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zach Dunn (zachdunn) merged 4 commits into from
Jul 7, 2026
+11 −1
Merged

fix(api): set Cache-Control: max-age=60 on uploads so overwrites propagate #10

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e8f024
fix(api): keep replaced uploads fresh at the edge
zachdunn Jul 7, 2026
98102fa
Merge remote-tracking branch 'origin/main' into claude/goofy-lichterm…
zachdunn Jul 7, 2026
00dffc2
docs(api): clarify purge scope — edge-only, Camo governs GitHub embeds
zachdunn Jul 7, 2026
52666a5
Drop purge-on-overwrite; keep max-age=60 as the fix
zachdunn Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/api/src/routes/files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ import { Hono } from "hono";
import { publicUrl, storage, storageConfig } from "../storage";
import type { WorkspaceVars } from "../workspace";

// The freshness floor on overwrite for every bucket. This is the operative lever
// for GitHub embeds: they're proxied through GitHub's Camo/Fastly cache, and
// max-age caps how long Camo serves a stale copy before revalidating against the
// (now-overwritten) origin. Without it, R2's custom-domain default (max-age=14400)
// kept replaced images stale for hours.
const UPLOAD_CACHE_CONTROL = "public, max-age=60";

const KEY_RE = /^[\w!*'()./-]+$/;

function badKey(key: string): boolean {
Expand All @@ -23,7 +30,10 @@ export const files = new Hono<WorkspaceVars>()

const ws = c.get("workspace");
const contentType = c.req.header("Content-Type") ?? "application/octet-stream";
await storage(c.env, ws).upload(key, new Uint8Array(body), { contentType });
await storage(c.env, ws).upload(key, new Uint8Array(body), {
contentType,
cacheControl: UPLOAD_CACHE_CONTROL,
});

const url = publicUrl(storageConfig(c.env, ws), key);
return c.json(
Expand Down