Repository navigation
Conversation
The React Native pages live under /sdk/react_native/, so the hyphenated spelling, which the other platform URLs suggest, returned 404. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Change-Id: Id75e8bc5903feeab5019d099b54502b3eda2b09b
|
Claude finished @krassx's task in 1m 57s —— View job Review of PR #102: redirect
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
🤖 Generated with [Claude Code](https://claude.com/claude-code) Change-Id: I11adda16859ed91d9e22c646585325eb7cc48692
|
Claude finished @krassx's task in 1m 14s —— View job Review of PR #102 (re-review after the new push): redirect
|
Path under build/sdk/react-native/ |
Redirects to |
|---|---|
index.html |
/sdk/react_native/installation/ |
installation/ |
/sdk/react_native/installation/ |
privacy/ |
/sdk/react_native/privacy/overview/ |
privacy/overview/ |
/sdk/react_native/privacy/overview/ |
Other checks
- The explicit redirects and the
createRedirectsaliases do not collide. The build raised no duplicate-redirect errors. - The
createRedirectsbranches for Android and React Native use disjoint prefixes, so their order doesn't matter.
Non-blocking notes (unchanged from before)
- The plugin emits client-side redirect pages (meta refresh plus JS), not HTTP 301s. That is fine for people. It is weaker for crawlers and for agents fetching raw
.mdcopies, because/sdk/react-native/installation.mdwill not exist. - The new comment above
createRedirectssits after the Android comment and reads as if it covers the whole function. That is cosmetic.
Overall risk: Low
Merge recommendation: Approve and merge.
Most important issues to fix: None.
Positives
- It reuses the existing redirect mechanism instead of adding duplicate pages.
- It keeps the
/sdk/react_native/paths canonical. - The follow-up commit closed the bare privacy path quickly.
- The PR description says what was left alone (
/sdk/capacitor/and/sdk/harmonyos/) and why.
· branchdocs/react-native-hyphen-redirect
https://docs.bugsee.com/sdk/react-native/returned 404: the React Native pages live under/sdk/react_native/. The other platforms' roots all answer./sdk/react-nativeroot to/sdk/react_native/installation/.createRedirectsaliases every/sdk/react_native/*page at/sdk/react-native/*.Verified with
npm run build(onBrokenLinks: 'throw'):build/sdk/react-native/,.../installation/and.../privacy/overview/all redirect to the underscore paths.Not changed:
/sdk/capacitor/and/sdk/harmonyos/also 404, but the docs have no pages for those platforms.🤖 Generated with Claude Code