Repository navigation
[merge after iOS SDK 7.0.0-beta7] e2e: un-pin OPT-007 body-without-type default on iOS (bugsee-cocoa#204) - #91
Draft
dsheikherev wants to merge 1 commit into
Draft
dsheikherev wants to merge 1 commit into
dsheikherev wants to merge 1 commit into
Conversation
bugsee-cocoa#239 fixes bugsee-cocoa#204: with capture.network.body-without-type at its default (false), iOS kept a response body with no Content-Type. The test that checks the default leaves such a body out was it.failing on iOS; it now runs on Android, the iOS simulator and iPhone, like its option-on sibling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after iOS SDK 7.0.0-beta7 is released and pinned in
native-versions.json. It needs bugsee/bugsee-cocoa#239, which fixes bugsee/bugsee-cocoa#204, to be in that release.Change
examples/bare/e2e/option-effects.test.ts:[OPT-007] capture.network.body-without-type at its default (false) leaves a response body with no Content-Type outwasit.failingon iOS. It is now a plain test on['A', 'S', 'X'], the same targets as its option-on sibling. The[known: …#204]suffix is gone, and the comment aboveuntypedBodiesdescribes the fixed state.With #239, iOS drops an HTTP body whose headers have no Content-Type unless the option is on, as Android does. This applies to both URLSession "complete" records: the one with headers only and the one with the body.
Until the pin moves to a release that has #239, a local or campaign run of
option-effectson iOS reports this test as a plain FAIL rather than a known one. CI is not affected:ios e2erunslaunch.test.tsonly.Checks
yarn typecheck,yarn lint: clean.yarn test: 3577 passed, 0 failed./bytes/64route:Content-Lengthonly.🤖 Generated with Claude Code