Skip to content

[merge after iOS SDK 7.0.0-beta7] e2e: un-pin OPT-007 body-without-type default on iOS (bugsee-cocoa#204) - #91

Draft
dsheikherev wants to merge 1 commit into
mainfrom
fix/body-without-type-ios
Draft

dsheikherev wants to merge 1 commit into
mainfrom
fix/body-without-type-ios

Conversation

@dsheikherev

Copy link
Copy Markdown
Contributor

Merge after iOS SDK 7.0.0-beta7 is released and pinned in native-versions.json. It needs bugsee/bugsee-cocoa#239, which fixes bugsee/bugsee-cocoa#204, to be in that release.

Change

examples/bare/e2e/option-effects.test.ts: [OPT-007] capture.network.body-without-type at its default (false) leaves a response body with no Content-Type out was it.failing on iOS. It is now a plain test on ['A', 'S', 'X'], the same targets as its option-on sibling. The [known: …#204] suffix is gone, and the comment above untypedBodies describes the fixed state.

With #239, iOS drops an HTTP body whose headers have no Content-Type unless the option is on, as Android does. This applies to both URLSession "complete" records: the one with headers only and the one with the body.

Until the pin moves to a release that has #239, a local or campaign run of option-effects on iOS reports this test as a plain FAIL rather than a known one. CI is not affected: ios e2e runs launch.test.ts only.

Checks

  • yarn typecheck, yarn lint: clean.
  • yarn test: 3577 passed, 0 failed.
  • The SDK side is covered by #239's round-trip tests. They go through a real URLSession against a local server that sends the same headers as the e2e stub's /bytes/64 route: Content-Length only.

🤖 Generated with Claude Code

bugsee-cocoa#239 fixes bugsee-cocoa#204: with
capture.network.body-without-type at its default (false), iOS kept a
response body with no Content-Type. The test that checks the default
leaves such a body out was it.failing on iOS; it now runs on Android,
the iOS simulator and iPhone, like its option-on sibling.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant