Repository navigation
[merge after iOS SDK 7.0.0-beta7] Drop detect.kill: iOS SDK 7.0.0-beta7 removes it - #90
Draft
dsheikherev wants to merge 1 commit into
Draft
dsheikherev wants to merge 1 commit into
dsheikherev wants to merge 1 commit into
Conversation
The iOS SDK registered com.bugsee.option.detect.kill but never read it (bugsee-cocoa#203) and removes it in 7.0.0-beta7 (bugsee-cocoa#237); Android never had it. - IOSLaunchOptions.detectAndReportKill: removed, with its accessor test. - option-keys.json: the key is gone, as cli-extract-option-keys.ts would produce from the SDK. - e2e: [OPT-068], the it.failing pin for #203 that waited for a report after SIGKILL, is removed with its `kill` scenario. No SDK reports a plain SIGKILL: iOS cannot tell it from a swipe-kill. - e2e ids are positions in option-keys.json, so the hardcoded ids after 068 move down by one (070 -> 069 ... 098 -> 097). BREAKING CHANGE: IOSLaunchOptions.detectAndReportKill is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after iOS SDK 7.0.0-beta7 is released and pinned in
native-versions.json. It follows bugsee/bugsee-cocoa#237, which removescom.bugsee.option.detect.killfrom the iOS SDK (bugsee/bugsee-cocoa#203: the key was registered, but nothing read it). Android never had the key.Change
IOSLaunchOptions.detectAndReportKillis removed, together with its accessor test. Breaking for users of the accessor. The package is still0.0.0and has no CHANGELOG. After beta7,setCustomOption('com.bugsee.option.detect.kill', …)becomes an unknown key: the SDK keeps it and nothing reads it, as before.option-keys.json: the key is removed. The iOS part now matches whatscripts/cli-extract-option-keys.tsproduces from the SDK branch (68 keys).[OPT-068] detect.killis removed, along with itskillscenario and its values inapi-constants.ts. It was anit.failingpin for #203 that waited for a report after SIGKILL. No SDK reports a plain SIGKILL, 6.x included: iOS cannot tell it from a swipe-kill. Out-of-memory kills are reported bydetect.exit.option-keys.json(optId()), so the hardcoded ids after 068 move down by one: 070→069, 071→070, 080→079, 081→080, 094→093, 098→097. TheoptId()-generated readback ids shift the same way.docs/design/2026-09-15-sdk-design.md:killDetectionis removed from theIOSLaunchOptionslist.Until beta7 is pinned, the fixture runs one key ahead of the pinned SDK (beta5 on main), which is harmless: the wrapper just stops sending a key the SDK ignores.
Verification
yarn typecheck,yarn lint: clean.yarn test: 3573 passed, 0 failed, 14 skipped.🤖 Generated with Claude Code