Skip to content

[merge after iOS SDK 7.0.0-beta7] Drop detect.kill: iOS SDK 7.0.0-beta7 removes it - #90

Draft
dsheikherev wants to merge 1 commit into
mainfrom
fix/drop-detect-kill
Draft

dsheikherev wants to merge 1 commit into
mainfrom
fix/drop-detect-kill

Conversation

@dsheikherev

Copy link
Copy Markdown
Contributor

Merge after iOS SDK 7.0.0-beta7 is released and pinned in native-versions.json. It follows bugsee/bugsee-cocoa#237, which removes com.bugsee.option.detect.kill from the iOS SDK (bugsee/bugsee-cocoa#203: the key was registered, but nothing read it). Android never had the key.

Change

  • IOSLaunchOptions.detectAndReportKill is removed, together with its accessor test. Breaking for users of the accessor. The package is still 0.0.0 and has no CHANGELOG. After beta7, setCustomOption('com.bugsee.option.detect.kill', …) becomes an unknown key: the SDK keeps it and nothing reads it, as before.
  • option-keys.json: the key is removed. The iOS part now matches what scripts/cli-extract-option-keys.ts produces from the SDK branch (68 keys).
  • e2e: [OPT-068] detect.kill is removed, along with its kill scenario and its values in api-constants.ts. It was an it.failing pin for #203 that waited for a report after SIGKILL. No SDK reports a plain SIGKILL, 6.x included: iOS cannot tell it from a swipe-kill. Out-of-memory kills are reported by detect.exit.
  • e2e ids are positions in option-keys.json (optId()), so the hardcoded ids after 068 move down by one: 070→069, 071→070, 080→079, 081→080, 094→093, 098→097. The optId()-generated readback ids shift the same way.
  • docs/design/2026-09-15-sdk-design.md: killDetection is removed from the IOSLaunchOptions list.

Until beta7 is pinned, the fixture runs one key ahead of the pinned SDK (beta5 on main), which is harmless: the wrapper just stops sending a key the SDK ignores.

Verification

  • yarn typecheck, yarn lint: clean.
  • yarn test: 3573 passed, 0 failed, 14 skipped.
  • e2e device runs: not done.

🤖 Generated with Claude Code

The iOS SDK registered com.bugsee.option.detect.kill but never read it
(bugsee-cocoa#203) and removes it in 7.0.0-beta7 (bugsee-cocoa#237);
Android never had it.

- IOSLaunchOptions.detectAndReportKill: removed, with its accessor test.
- option-keys.json: the key is gone, as cli-extract-option-keys.ts
  would produce from the SDK.
- e2e: [OPT-068], the it.failing pin for #203 that waited for a report
  after SIGKILL, is removed with its `kill` scenario. No SDK reports a
  plain SIGKILL: iOS cannot tell it from a swipe-kill.
- e2e ids are positions in option-keys.json, so the hardcoded ids after
  068 move down by one (070 -> 069 ... 098 -> 097).

BREAKING CHANGE: IOSLaunchOptions.detectAndReportKill is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@dsheikherev
dsheikherev requested a review from krassx October 15, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant