Skip to content

system traces: sameValue JSON.stringify guard can throw on circular/BigInt values #56

Open

Description

@krassx

TraceProducerBase.emitIfChanged de-dups with a JSON.stringify-based sameValue (packages/capture/src/trace-producer.ts). A circular or BigInt value makes it throw. The provider isolates producer errors, so the trace is dropped rather than crashing, but the value is silently lost.

Fix: a total comparison (structural, or try/catch falling back to "changed"). Test-first with circular and BigInt cases.

Deferred from PR #55 (trace producers over shared trackers).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions