Skip to content

feat: expose runtime model options#243

Merged
frostming merged 4 commits into
bubbuild:mainfrom
Leeeon233:feat-acp-config-options
Jul 3, 2026
Merged

feat: expose runtime model options#243
frostming merged 4 commits into
bubbuild:mainfrom
Leeeon233:feat-acp-config-options

Conversation

@Leeeon233

@Leeeon233 Leeeon233 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Add RuntimeOption for ACP. Related PR: bubbuild/bub-contrib#45

@Leeeon233 Leeeon233 marked this pull request as ready for review June 18, 2026 13:32
@frostming

Copy link
Copy Markdown
Collaborator

@Leeeon233 need to resolve conflicts, especially #244 , which stores model in the state dict.

# Conflicts:
#	src/bub/builtin/hook_impl.py
#	src/bub/framework.py
#	tests/test_builtin_hook_impl.py
#	tests/test_framework.py
@Leeeon233

Copy link
Copy Markdown
Contributor Author

@frostming Done. I can get model list from ACP now.

Comment thread src/bub/channels/message.py Outdated
Comment thread src/bub/builtin/hook_impl.py Outdated
Comment thread tests/test_builtin_hook_impl.py Outdated
@frostming frostming merged commit 59874d8 into bubbuild:main Jul 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants