Fix adding USD subscriptions when USD is not the default currency - #129
Open
zbrox wants to merge 1 commit into
Open
Fix adding USD subscriptions when USD is not the default currency#129zbrox wants to merge 1 commit into
zbrox wants to merge 1 commit into
Conversation
Owner
|
Almost done reviewing this |
bscott
approved these changes
Aug 5, 2026
bscott
left a comment
bscott
left a comment
Owner
There was a problem hiding this comment.
Reviewed. New subscription forms now use the preferred currency, edit forms preserve the subscription's original currency, and the visible cost symbol stays synchronized with the selection. The handler and template coverage is useful rather than incidental. GitHub CI passes; I also ran the new Chromium flow successfully and ran go test ./..., go vet ./..., and go build ./... with the other ready v0.6.5 candidates. Ready to stage.
Owner
|
Approved and queued — this merges right after the v0.6.5 release ships, and then #131 rebases on top of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I experienced this issue when trying to add subscriptions which are predominantly in SEK. But I have a few in USD.
When opening the add new subscription modal the dropdown for currency was still showing USD and the prefix for the cost input was however "kr" (the symbol for SEK). Selecting a different currency in the dropdown did not change the prefix.
Furthermore when leaving it as USD it would still add the subscription as the default currency.
This PR fixes the issue.