Add currency support for UAH - #128
Open
zbrox wants to merge 1 commit into
Open
Conversation
Owner
|
Almost done reviewing this |
bscott
approved these changes
Aug 5, 2026
bscott
left a comment
bscott
left a comment
Owner
There was a problem hiding this comment.
Reviewed. This is a focused addition using the existing shared currency registry, with the correct UAH code and hryvnia symbol and no unrelated changes or dependencies. GitHub CI passes, and it also passed go test ./..., go vet ./..., and go build ./... in the combined v0.6.5 candidate. Ready to stage.
Owner
|
Approved and queued for merge right after the v0.6.5 release ships. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is already in the list of supported currencies at Fixer.io
Tested locally with Go 1.26.5:
go test ./... passes, including internal/service currency coverage.