fix(bundling): Rebundle when an imported script or style dependency changes - #110
Merged
Conversation
✅ Deploy Preview for maudit-framework ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental builds only fingerprinted script and style entry files, so editing a module imported by an
include_scriptentry (or a CSS partial pulled in via@import) left the cache thinking nothing had changed, and the build served a stale bundle.Bundling now also fingerprints each chunk's source module graph and the
@importgraph, so a change to an imported file triggers a rebundle.d437432covered a neighbouring case — assets Rolldown emits separately, like fonts and WASM — but imported JS modules are inlined into a chunk rather than emitted as assets, so they were never tracked.Adds regression tests for both the JS and CSS cases.