Bug: Warmup Assertions - #563
Merged
Merged
Conversation
The per-commit test schema starts empty and upload_results only fires in on-run-end, after tests. A single dbt build therefore asserts against empty marts, making assert_consumption_daily_has_smb, assert_run_health_daily_has_invocations and assert_model_performance_valid unpassable on a fresh schema. Run a test-excluded build first to populate the source tables, then the real build. Adds ~43s per Snowflake leg.
The build command was commented out in 151d13c, a broad tox refactor that reordered every env; no reason was recorded and the neighbouring 1.3-1.8 envs kept theirs. release.yml already schedules a snowflake/1_9_0 slot, so that slot has been running clean+deps and reporting green while validating nothing. We advertise 1.9 support via require-dbt-version, so it should be tested. Verified green with no other changes needed: PASS=129 ERROR=0.
The test's comment claimed lineage_edges must be non-empty, but the only branch keyed off models_with_deps, which is itself empty when the mart is empty -- so it passed vacuously on a fresh schema. Add an explicit empty_mart branch. Verified it now fails (Got 1 result) on a single build against a fresh schema, and passes with the warm-up in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Assertion tests need to be warmed. This PR does so for CI