[WIP] Brigadeterm - #12
Conversation
Ensure Brigade terminal exists Signed-off-by: Radu M <root@radu.sh>
Signed-off-by: Radu M <root@radu.sh>
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
I just saw the WIP label on this so I might have jumped the gun - I know you were already reworking the terminal stuff, and please ignore other comments if already in hand!
| const brigadeNamespace = config.getConfiguredNamespace() || 'default'; | ||
| const cmd = `${bin} --namespace ${brigadeNamespace}`; | ||
|
|
||
| const terminal = ensureTerminal(); |
There was a problem hiding this comment.
This needs to handle the case where a CLI dashboard is already running. You don't want to send this text to a terminal that is already running brigadeterm. We should either:
- Open a new
brigadeterminstance each time; or - If there is already a
brigatetermopen then switch to it, otherwise open a new terminal.
| { | ||
| "command": "brigade.openCliDashboard", | ||
| "category": "Brigade", | ||
| "title": "Open CLI Dashboard (Brigadeterm)" |
There was a problem hiding this comment.
Terminal Dashboard might align more closely to the program name (and the dashboard itself is not a CLI...)?
| vscode.commands.registerCommand("brigade.rerunBuild", onCommandRerunBuild), | ||
| vscode.commands.registerCommand("brigade.refreshProjectExplorer", onCommandRefreshProjectExplorer), | ||
| vscode.commands.registerCommand("brigade.openWebDashboard", openWebDashboard), | ||
| vscode.commands.registerCommand("brigade.openCliDashboard", openCliDashboard), |
There was a problem hiding this comment.
Longer term it would be good to be able to right-click a project or build and open the dashboard to that object. That doesn't need to be in the first cut though.
2 participants
depends on #11