Skip to content

fix: footer should not fix to the bottom #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CIPHERTron wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: footer should not fix to the bottom #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a85bed2
fix: footer should not fix to the bottom
CIPHERTron Mar 23, 2022
411053b
stick footer at bottom when content is less
CIPHERTron Mar 29, 2022
606036f
Merge branch 'main' into fix-footer
krancour Mar 30, 2022
38132b2
fix: revert changes made to footer
CIPHERTron Apr 1, 2022
64a8662
Merge branch 'fix-footer' of https://github.com/CIPHERTron/brigade-da…
CIPHERTron Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,16 @@ $text: #647b83;
$work: "work_sansregular", "Work Sans", "Helvetica Neue", Helvetica, Arial,
Geneva, sans-serif;

html {
height: 100%;
}

body {
font-family: $work !important;
padding-bottom: 80px;
position: relative;
margin: 0;
padding-bottom: 5rem;
min-height: 100%;
}

a:not(.nav-link) {
Expand Down Expand Up @@ -77,3 +84,10 @@ a:not(.nav-link) {
color: $text !important;
}
}

footer {
position: absolute;
right: 0;
bottom: 0;
left: 0;
}
2 changes: 1 addition & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class App extends React.Component<unknown, AppState> {
</Container>
</main>
<footer>
<Navbar bg="dark" variant="dark" expand="lg" fixed="bottom">
<Navbar bg="dark" variant="dark" expand="lg">
<Container>
<span className="text-muted">
&copy; 2022 The Brigade Authors
Expand Down