Repository navigation
Construct legacy Dataset IDs from selected roots without changing coverage - #4676
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default legacy construction omitted required
Dataset.ideven when the selectedRO-Crate root supplied an identifier. Add one explicit
root_identifier_v1TSVroute, shared by both legacy implementations: scalar root
identifier, thenroot
@id; recognized DOI prefixes becomedoi:while preserving the completesuffix. Ambiguous and non-text assertions refuse, and custom unmarked mappings
retain their prior behavior.
Merged identity comes only from the configured primary; secondary identities
remain evidence in the existing report. The construction row is excluded from
informativeness and source-coverage calculations so ranking and automatic
primary selection keep their original basis. Existing reverse DOI lookup,
mandatory schema validation, source inputs and historical artifacts remain
preserved. Other default mapping errors still refuse publication.
Validation: 570 focused tests passed. Both implementations replayed five pinned
inputs in original and reversed graph order (20 runs per arm). Full records
changed only by ID; each error list lost only the missing-ID failure. The actual
publication gate still refused 16/20 candidate drafts; only the four equivalent
VOICE provenance runs passed. Complete score/rank results and primary selections
matched, with eight software-only merge comparisons per arm retaining every
non-ID field and provenance entry. Both complete checkout content inventories
matched before/after replay, including hidden and ignored files outside
.git.Independent adversarial review and final verification of all compact evidence passed.
See
notes/legacy_root_identity_2026-10-08/README.mdandvalidation.json.This change is based on tested DOI successor
1a98255bb28451500d4864876a16d9c6c2f6b435; PR #4673 must merge first.Closes #4672.
Closes #4674.
Parent #4594 and #2915 remain open. This does not claim improved scientific
coverage, semantic exactness, or completion of the five-input publication
obligations.