Skip to content

Initialise create.legend.labels so guideline = FALSE draws its legend #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braverock merged 1 commit into from
Sep 19, 2026
Merged

Initialise create.legend.labels so guideline = FALSE draws its legend #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions R/charts.efficient.frontier.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,13 @@ chart.EfficientFrontierCompare <- function(R, portfolio, risk_type, n.portfolios
}

# legend
# The guideline block below is the only place create.legend.labels is built,
# but it is used unconditionally when legend.labels is NULL. Without this
# initialisation the function fails with "object 'create.legend.labels' not
# found" for guideline = FALSE. NULL is the right empty value: append() drops
# it, leaving one label per match.col, which is exactly the number of colours,
# line types and widths the guideline = FALSE branch sets above.
create.legend.labels <- NULL
if(guideline){
lines(x=c(out$frontier[1,1], out$frontier[1,m.p]), y = rep(out$frontier[1,2], 2), lty=lty[3], col=col[3], lwd=lwd[3])
points(x=c(out$frontier[1,1], out$frontier[1,m.p]), y = rep(out$frontier[1,2], 2), pch=pch.assets, cex=cex.assets)
Expand Down