Block requests to localhost and similar, when not on localhost and similar - #463
Conversation
|
add an anchor |
|
@antonok-edm uBO doesn't like ipv6, can adblock-rust work with ::1? |
13239e5 to
c90cc01
Compare
|
change |
c90cc01 to
5c2d4eb
Compare
ryanbr
left a comment
ryanbr
left a comment
There was a problem hiding this comment.
If ::1 is fine then this is okay.
| ||localhost^$third-party,domain=~127.0.0.1|~::1|~local | ||
| ||127.0.0.1^$third-party,domain=~localhost|~::1|~local | ||
| ||::1^$third-party,domain=~localhost|~127.0.0.1|~local | ||
| .local^$third-party,domain=~localhost|~127.0.0.1|~::1 No newline at end of file |
There was a problem hiding this comment.
These won't work as-is, but if you change them to [::1], they do work correctly.
I'll add these as tests to adblock-rust.
|
I would also consider changing from .local^$.. to ||local^$... |
|
oh also, I don't think |
|
okie dokie, will hold off on more changes until you report back :) |
b837618 to
14a5824
Compare
|
okie as discussed, going to solve this by splitting into two PRs, this one w/o .local, and #465 which adds back in the .local addresses |
14a5824 to
37a5238
Compare
4 participants
fixes #462