remove invisible cookie modal backdrop on xm.com - #2888
Open
petport wants to merge 2 commits into
Open
Conversation
Author
|
Hello brave team! Any comments in this PR? If there are any issues, I would love to discuss more optimal solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a WebCompat issue on xm.com where Brave's cookie-blocking component successfully hides the visual aspect of the cookie consent modal, but leaves the underlying backdrop wrapper (.cdk-overlay-container) active in the DOM. This invisible container blankets the viewport and traps mouse events, preventing users from clicking "Start Trading" or interacting with the page in general.
Steps to Reproduce (STR)
Fix
Added a procedural filter targeting .cdk-overlay-container only when it contains xm-cookie-modal-main to clear the un-clickable layout layer without interfering with other potential system modals.