add tradingpaints + paintbuilder to localhost permission list - #2727
Open
gu3st wants to merge 1 commit into
Open
add tradingpaints + paintbuilder to localhost permission list#2727gu3st wants to merge 1 commit into
gu3st wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trading Paints (and it's related site Paint Builder) communicate with a local desktop application in order to refresh users selected paints as they navigate the website as well as allow them to preview their works in progress directly in the iRacing Paint Shop or iRacing Simulator.
Before attempting accessing the local service, the user is prompted via a notification bar/modal informing them why Trading Paints is asking for this access and allowing them to choose to allow it or not.
Currently Brave doesn't implement the local-network-access permission correctly and in "Shields Up" mode blocks requests with seemingly no way to add a site to an allow list and in "Shields Down" always returns "prompt" without ever actually prompting the user to allow or reject the local network access and allows the request.
More Info as to how the permission is used: https://help.tradingpaints.com/general/why-is-trading-paints-asking-to-look-for-and-connect-to-any-device-on-my-local-network/