Avoid login during OTEL logger startup#2163
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71f4c8a4d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d94b2ab51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a9a2bc2d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e99deb3c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| await expect(formatSpanTreeSnapshot(events)).toMatchFileSnapshot( | ||
| snapshotPath.replace(/\.json$/, ".txt"), | ||
| ); | ||
| await expect(formatSpanTreeJsonSnapshot(events)).toMatchFileSnapshot( | ||
| snapshotPath, |
There was a problem hiding this comment.
In canary mode, matchFileSnapshot in e2e/helpers/file-snapshot.ts intentionally writes the snapshot and returns without failing, so provider drift is handled by the canary update workflow. These direct toMatchFileSnapshot calls bypass that wrapper, so the Claude Agent SDK canary assertions will now fail on expected span-tree drift instead of updating/passing as before; keep using matchSpanTreeSnapshot/matchFileSnapshot here or route both snapshots through the wrapper.
Useful? React with 👍 / 👎.
1 participant
Context
Reduce startup login traffic for mixed OTEL + logger initialization in the JS SDK.
Description