Skip to content

Session: session/epic-415-epic-fail-closed-on-shipping-the-loop-merges-before-checks-report-and-reports-mutations-that-never-happened — 2/2 succeeded - #419

Open
bradtaylorsf wants to merge 5 commits into
masterfrom
session/epic-415-epic-fail-closed-on-shipping-the-loop-merges-before-checks-report-and-reports-mutations-that-never-happened
Open

bradtaylorsf wants to merge 5 commits into
masterfrom
session/epic-415-epic-fail-closed-on-shipping-the-loop-merges-before-checks-report-and-reports-mutations-that-never-happened

Conversation

@bradtaylorsf

@bradtaylorsf bradtaylorsf commented Aug 15, 2026 •

Copy link
Copy Markdown
Owner

Session Summary

Branch: session/epic-415-epic-fail-closed-on-shipping-the-loop-merges-before-checks-report-and-reports-mutations-that-never-happened
Issues processed: 2 (2 succeeded, 0 failed, 0 waiting, 0 recovered)
Total duration: 46 minutes
Completed: 2026-08-15T21:41:23.902Z

Issues

Closes #412
Closes #404

Session Review

Status: PASSED
Summary: Fixed three merge-gate integration defects; build, boot, and all 1,575 tests pass.

  • [CRITICAL] mergePR treated a zero-exit gh pr merge command as proof that the PR landed, but GitHub can instead enqueue a merge-queue PR; it now verifies state=MERGED and mergedAt before reporting success. (fixed) — src/lib/github.ts
  • [WARNING] The merge gate classified GitHub's neutral and skipped terminal conclusions as failures even though GitHub treats both as successful for merge requirements. (fixed) — src/lib/github.ts
  • [WARNING] Check polling used synchronous gh queries without command timeouts, so a stalled query could exceed the configured registration and overall merge-gate deadlines; each query is now bounded by the nearest remaining deadline. (fixed) — src/lib/github.ts
  • [INFO] pnpm audit reports eight pre-existing advisories in Jest-only transitive dependencies (brace-expansion and js-yaml); no production dependency or session-added package is affected. — pnpm-lock.yaml

This PR collects all changes from this session for final review before merging to master.

Automated by alpha-loop

…e-loop-merges-before-checks-report-and-reports-mutations-that-never-happened
…-success generators (incl. mergePR) (closes #412) (#425)

* feat: fix: remaining warn-and-return-void mutation wrappers are false-success generators (incl. mergePR) (closes #412)

* fix: address review findings for #412
…any check can report (closes #404) (#427)

* feat: fix: fail closed on merge — the loop merges its own PRs before any check can report (closes #404)

* fix: address review findings for #404
…he-loop-merges-before-checks-report-and-reports-mutations-that-never-happened

Processed 2 issue(s) in this session.
@bradtaylorsf bradtaylorsf changed the title Epic #415: epic: fail closed on shipping — the loop merges before checks report, and reports mutations that never happened Session: session/epic-415-epic-fail-closed-on-shipping-the-loop-merges-before-checks-report-and-reports-mutations-that-never-happened — 2/2 succeeded Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant