Skip to content

fix: Make MayNotUseNamespaceRule match forbidden namespaces case-insensitively #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Oct 4, 2026
Merged

fix: Make MayNotUseNamespaceRule match forbidden namespaces case-insensitively #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Analyser/NodeQueryTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@

use function in_array;
use function rtrim;
use function str_starts_with;
use function strcasecmp;
use function strlen;
use function strncasecmp;

/**
* Query helpers shared by {@see ClassNode}, {@see AnonymousClassNode},
Expand Down Expand Up @@ -48,10 +49,13 @@ public function dependsOn(string $class, bool $isCaseSensitive = true): bool

public function dependsOnNamespace(string $namespace): bool
{
$prefix = rtrim($namespace, '\\') . '\\';
$prefix = rtrim($namespace, '\\') . '\\';
$prefixLength = strlen($prefix);

// namespace names are case-insensitive; only the prefix is compared,
// so a case-sensitive constant name after it is left untouched
foreach ($this->dependencies as $dependency) {
if (str_starts_with($dependency, $prefix)) {
if (strncasecmp($dependency, $prefix, $prefixLength) === 0) {
return true;
}
}
Expand Down
16 changes: 16 additions & 0 deletions tests/Rule/Usage/MayNotUseNamespaceRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,22 @@ public function testViolatesWhenForbiddenNamespaceHasTrailingBackslash(): void
$this->assertInstanceOf(RuleViolation::class, $mayNotUseNamespaceRule->evaluate($classNode));
}

public function testViolatesWhenDepIsInForbiddenNamespaceWithDifferentCase(): void
{
$mayNotUseNamespaceRule = new MayNotUseNamespaceRule(layer: 'Domain', forbiddenNamespace: 'App');
$classNode = $this->makeNode(['app\\B']);

$this->assertInstanceOf(RuleViolation::class, $mayNotUseNamespaceRule->evaluate($classNode));
}

public function testPassesWhenDepIsTheForbiddenNamespaceItself(): void
{
$mayNotUseNamespaceRule = new MayNotUseNamespaceRule(layer: 'Domain', forbiddenNamespace: 'App');
$classNode = $this->makeNode(['App']);

$this->assertNotInstanceOf(RuleViolation::class, $mayNotUseNamespaceRule->evaluate($classNode));
}

public function testPassesWhenDepOnlySharesNamespacePrefix(): void
{
$mayNotUseNamespaceRule = new MayNotUseNamespaceRule(layer: 'Domain', forbiddenNamespace: 'Doctrine\\ORM');
Expand Down
Loading