You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Repro: parse a truncated document like {"some key here": with test/checking_resource.hpp as the resource. The abandoned key fails alignment == it->second.second.
Cause: string_impl::destroy frees a key string with the default alignment (max_align), but both key_t constructors allocate it with alignof(char). The default resource ignores the argument, so this only bites upstreams that bucket by alignment.
Fix: pass alignof(char) to match the allocation. Both test cases fail before the fix and pass after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #1179 as requested.
Repro: parse a truncated document like
{"some key here":withtest/checking_resource.hppas the resource. The abandoned key failsalignment == it->second.second.Cause:
string_impl::destroyfrees a key string with the default alignment (max_align), but bothkey_tconstructors allocate it withalignof(char). The default resource ignores the argument, so this only bites upstreams that bucket by alignment.Fix: pass
alignof(char)to match the allocation. Both test cases fail before the fix and pass after.