Skip to content

Do not show the all products collection in sidebar if it is hidden - #42

Merged
dabrorius merged 1 commit into
mainfrom
feature/sc-3122-hidden-system-collection-is-still-shown-in-sidebar-in
Aug 28, 2026
Merged

dabrorius merged 1 commit into
mainfrom
feature/sc-3122-hidden-system-collection-is-still-shown-in-sidebar-in

Conversation

@dabrorius

Copy link
Copy Markdown
Contributor

Why

We got a report from a customer that they have hidden their "All products" collection, but it still appears in the sidebar of booking page. Turns out we had it hard-coded there without a check if it is hidden.

Links

Resolves SC-3122

Media

Before

Screenshot 2026-08-28 at 14 56 13 Screenshot 2026-08-28 at 14 56 30

After

Screenshot 2026-08-28 at 14 56 37

@dabrorius
dabrorius requested review from srgzlb and a lite review from Copilot August 28, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the booking page sidebar navigation so the system “All products” collection is only shown when it’s configured to be visible (i.e., not hidden), matching expected storefront behavior.

Changes:

  • Wraps the “All products” sidebar link in a visibility check (all_products.show_in_store) so hidden system collections are not rendered.
  • Keeps existing rendering of non-system collections unchanged.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dabrorius
dabrorius merged commit 37d7ab3 into main Aug 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants