Repository navigation
fix: keep zh_CN.lproj in macOS builds - #61
Merged
Merged
Conversation
electronLanguages matched locale names literally, so zh-CN kept zh-CN.pak on Windows/Linux but stripped zh_CN.lproj from the macOS bundle. The Mac App Store derives supported languages from .lproj folders and listed twig as English-only. List both spellings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electronLanguages: [en-US, zh-CN]. electron-builder matches locale file names literally (exact, or<name>-/<name>_prefix). Windows/Linux usezh-CN.pak, which matches; macOS useszh_CN.lproj, which does not, so it was stripped from the bundle. The App Store derives supported languages from the.lprojfolders.dist/mas-arm64/twig.app/Contents/Resourcescontains onlyen.lproj, whileCFBundleLocalizationsalready declaresenandzh-CN.zh-CN(pak) andzh_CN(lproj).Validation
en.lproj,zh_CN.lprojen-US.pak,zh-CN.pak(unchanged)twig.app/Contents/Resources/zh_CN.lprojexists.🤖 Generated with Claude Code