Bazel: migrate lint/style checks to native Bazel configuration & add clean-coverage target - #221
Open
NikitaJangidBMW wants to merge 3 commits into
Open
Bazel: migrate lint/style checks to native Bazel configuration & add clean-coverage target#221NikitaJangidBMW wants to merge 3 commits into
NikitaJangidBMW wants to merge 3 commits into
Conversation
NikitaJangidBMW
force-pushed
the
internal/replace-make-with-bazel-target
branch
from
July 20, 2026 11:52
b5845d6 to
34cd3a4
Compare
NikitaJangidBMW
force-pushed
the
internal/replace-make-with-bazel-target
branch
from
July 21, 2026 07:19
df631db to
349970a
Compare
hoe-jo
self-requested a review
July 22, 2026 04:41
hoe-jo
requested changes
Jul 22, 2026
hoe-jo
left a comment
Contributor
There was a problem hiding this comment.
For Lint and Format already aspect rules lint is setup in Bazel, see
tools/lint -> pylint + ty (maybe change to pylint + ruff)
tools/format (-> ruff and buildifier)
phiwuu
requested changes
Jul 23, 2026
phiwuu
left a comment
Member
There was a problem hiding this comment.
Please also update the section on make lint in file documentation/dev_setup.md
Author
@hoe-jo Thanks, that makes sense. We should reuse the existing Bazel lint/format pipeline rather than add parallel wrappers. The only concern is that replacing ty with ruff would drop type-checking coverage, since ruff is not a type checker. |
NikitaJangidBMW
force-pushed
the
internal/replace-make-with-bazel-target
branch
2 times, most recently
from
July 27, 2026 06:48
255b6b5 to
e6249ab
Compare
NikitaJangidBMW
force-pushed
the
internal/replace-make-with-bazel-target
branch
from
July 27, 2026 07:39
e6249ab to
d942852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate code quality checks from make lint to Bazel's native linting via
aspect_rules_lint,and add a reusable cleanup target.
BUILD
sh_binarytarget//:clean-coverage-> executes cleanup script (equiv.make clean-coverage)requirements_*) asmanualto prevent inclusion in default build setMODULE.bazel
rules_shell@0.6.1— needed for shell script execution.github/workflows/ci.yml
bazel-contrib/setup-bazel@0.19.0with caching enabledmake lintwithbazel build --config=lint //...util/BUILD (new)
clean_coverage.shfor use as Bazel labelutil/clean_coverage.sh (new)
make clean-coverageshell invocationrequirements_dev.txt
pylint<4.0→pylint>=3,<4.0for flexibilityAdditional
.bazelrc: Update lint aspects path from//tools/lint→//third_party/linttools/sphinx/BUILD: Tag requirements targets asmanualtrlc/BUILD: Add filegrouppy_sources