fix(skills): pass --project-root to the customization resolver - #37
Merged
Conversation
Core's resolve_customization.py inferred the project root when the flag was absent, and for a skill installed under the user's home that inference walked up to ~ — where a user-level install's ~/_bmad made home look like the project. Team overrides in the real project were silently ignored: no error, no warning, just shipped defaults. The resolver itself is fixed in BMAD-METHOD#2802, which is what actually repairs existing installs since this module ships no copy of the script. This is the hardening half: passing the root explicitly leaves nothing to infer, and matches resolve_config.py, which has always required it. No behaviour change where the inference already landed correctly. The flag has always existed, so new skill text works against an old resolver and old text against the new one. Refs bmad-code-org/BMAD-METHOD#2796 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8Hyqmp2giAVgEAnB49zEQ
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (45)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe change updates agent and workflow instructions so every ChangesCustomization Resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change makes customization resolution use the project root explicitly without changing behavior where resolution already worked correctly; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (45 skipped: 45 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bmadcode
added a commit
that referenced
this pull request
Aug 31, 2026
Covers #37. Bumps .claude-plugin/marketplace.json to 0.7.2, which the release workflow does not touch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8Hyqmp2giAVgEAnB49zEQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--project-root {project-root}to all 60resolve_customization.pyinvocation sites across 45 files — agent skills, the 3-technical and 4-production workflows, and their external step files.Why
resolve_customization.pyinferred the project root when--project-rootwas absent, walking up from the skill's installed directory. For a skill installed under the user's home that walk reaches~— and a user-level install's~/_bmadmade home look like the project. Team overrides in the real project were silently ignored: no error, no warning, just shipped defaults.The resolver itself is fixed in bmad-code-org/BMAD-METHOD#2802. That is what actually repairs existing installs — this module ships no copy of the script and calls core's at
{project-root}/_bmad/scripts/, so it inherits the fix on upgrade with nothing to do here.This PR is the hardening half. Passing the root explicitly leaves nothing to infer, and matches
resolve_config.py, which has always required the flag.Safety
No behaviour change wherever the inference already landed correctly, which is the common case.
--project-roothas always existed, so there is no version skew in either direction: new skill text works against an old resolver, and old text against the new one. This can merge before or after #2802.Refs bmad-code-org/BMAD-METHOD#2796
🤖 Generated with Claude Code
https://claude.ai/code/session_01L8Hyqmp2giAVgEAnB49zEQ
Summary by CodeRabbit